Optimize ripper translator token sorting#3870
Merged
Merged
Conversation
eregon
approved these changes
Jan 25, 2026
eregon
left a comment
eregon
left a comment
Member
There was a problem hiding this comment.
Smart, sorting by byte offset is even faster and converting line to byte offset is just an Array#[] :)
eregon
reviewed
Jan 25, 2026
Earlopain
force-pushed
the
ripper-translator-optimize-sort
branch
from
January 25, 2026 20:32
a107256 to
ddec3a7
Compare
With the benchmark from ruby@2ea8139 Prism is: * 1.33x slower before * 1.07x slower after
Earlopain
force-pushed
the
ripper-translator-optimize-sort
branch
from
January 25, 2026 20:33
ddec3a7 to
a18b0ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the benchmark from 2ea8139 Prism is: